Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow not setting replicas for deployments #4057

Merged
merged 1 commit into from
May 3, 2023
Merged

allow not setting replicas for deployments #4057

merged 1 commit into from
May 3, 2023

Conversation

grosser
Copy link
Contributor

@grosser grosser commented May 3, 2023

ideally that would be automatic, but that could break lots of things ... so using a flag to opt-in instead

also: cleaning up support for ShardedDeployment since that is EOL

Risks

  • Low: deploys failing on some kinds being configured with multiple replicas

@grosser grosser requested a review from a team as a code owner May 3, 2023 00:04
a7i
a7i approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@a7i a7i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@grosser
Copy link
Contributor Author

grosser commented May 3, 2023

had to also add that server-side-apply is enabled or this ends up setting 1, since that's the replica default when using "replace" workflow

@grosser grosser merged commit 343f11d into master May 3, 2023
8 of 10 checks passed
@grosser grosser deleted the grosser/norep branch May 3, 2023 02:34
@grosser grosser mentioned this pull request May 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7i a7i a7i approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grosser @a7i