Bump audited gem to latest #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zendesk-mattlefevre
changed the title
grosser
reviewed
Nov 16, 2023
grosser
reviewed
Nov 16, 2023
| @@ -247,7 +247,7 @@ def assert_content(files) | |||
| next if association.name == :audits # should never be destroyed | |||
| next if association.options.key?(:through) # already cleaned up via through relation | |||
| next if association.options.key?(:dependent) # already defined | |||
| next if association.is_a?(Doorkeeper::Application) && association.name == :authorized_tokens | |||
| next if association.name == :authorized_tokens # removed only when user is deleted; otherwise soft deleted | |||
There was a problem hiding this comment.
seems a bit sus ... but if it works 🤷
There was a problem hiding this comment.
This was the exception we talked about for the Doorkeeper gem bump merged in yesterday. Not sure why the specs decided to grump about the syntax today, rather than yesterday when I was actually working on this 😅
sarahjmiller
approved these changes
Nov 16, 2023
grosser
approved these changes
Nov 16, 2023
zendesk-mattlefevre
deleted the
zendesk-mattlefevre/upgrade-audited-gem
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Striving to catch up on getting gems bumped to latest versions, this PR aims to get the
auditedgem up to latest.Risks