Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substitute $environment in k8s role config file #4083

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Substitute $environment in k8s role config file #4083

merged 1 commit into from
Dec 6, 2023

Conversation

adammw
Copy link
Contributor

@adammw adammw commented Dec 5, 2023

Note: Samson is a public repo, do not include Zendesk-internal information, urls, etc.

  • Substitute $environment in k8s role config file

References

Risks

  • Low: could break the kubernetes config file mapping logic, breaking kubernetes deploys

@adammw adammw requested a review from a team as a code owner December 5, 2023 05:39
grosser
grosser approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition

@adammw adammw force-pushed the adammw/dynamic-role-config-subst branch from a16ce50 to 706bb7e Compare December 6, 2023 03:03
@adammw adammw force-pushed the adammw/dynamic-role-config-subst branch from 706bb7e to 481d48d Compare December 6, 2023 04:49
@adammw adammw merged commit a4f9283 into master Dec 6, 2023
9 checks passed
@adammw adammw deleted the adammw/dynamic-role-config-subst branch December 6, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grosser grosser grosser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adammw @grosser