kubernetes: dynamic file name based on deploy_group permalink #4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7i
force-pushed
the
amir/deploy-group-permalink
branch
3 times, most recently
from
20b34c8
to
9c8414a
Compare
a7i
commented
Dec 18, 2023
| @@ -164,6 +164,7 @@ def role_config_file(reference, deploy_group:, project: project(), **args) # rub | |||
| file = config_file | |||
| if deploy_group && dynamic_folders? | |||
| file = file. | |||
| sub('$deploy_group_permalink', deploy_group.permalink). | |||
There was a problem hiding this comment.
it has to come before $deploy_group otherwise it will replace it to pod998_permalink
Signed-off-by: Amir Alavi <amir.alavi@zendesk.com>
a7i
force-pushed
the
amir/deploy-group-permalink
branch
from
9c8414a
to
e66f2a1
Compare
grosser
approved these changes
Dec 18, 2023
|
wasn't needed so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Samson is a public repo, do not include Zendesk-internal information, urls, etc.
References
Risks