-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Webhooks for Pull Requests #746
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c8c1957
Enable webhooks for Pull Requests
7809e41
merge master
b8c8257
address pull request comments
9b239fa
do not automatically run webhook if based on production
09b7530
prevent api call for pull request data
2d6a0cb
update pull request changeset_from_webhook test
b8229ed
make webhook regex more unique
ad71fee
remove unnecessary cache clear
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
class Changeset::CodePush | ||
attr_reader :repo, :data | ||
|
||
def initialize(repo, data) | ||
@repo = repo | ||
@data = data | ||
end | ||
|
||
def self.changeset_from_webhook(project, params = {}) | ||
new(project.github_repo, params) | ||
end | ||
|
||
def self.valid_webhook?(_) | ||
true | ||
end | ||
|
||
def sha | ||
data[:after] | ||
end | ||
|
||
def branch | ||
data[:ref][/refs\/heads\/(.+)/, 1] | ||
end | ||
|
||
def service_type | ||
'code' # Samson webhook category | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
class Changeset::IssueComment | ||
attr_reader :repo, :data | ||
|
||
def initialize(repo, data) | ||
@repo = repo | ||
@body = data['body'] | ||
@data = data['issue'] | ||
end | ||
|
||
def self.changeset_from_webhook(project, params = {}) | ||
new(project.github_repo, params) | ||
end | ||
|
||
def self.valid_webhook?(params) | ||
comment = params[:comment] || {} | ||
comment[:body] =~ Changeset::PullRequest::WEBHOOK_FILTER | ||
end | ||
|
||
def sha | ||
pull_request.sha | ||
end | ||
|
||
def branch | ||
pull_request.branch | ||
end | ||
|
||
def service_type | ||
'pull_request' # Samson webhook category | ||
end | ||
|
||
private | ||
|
||
def pull_request | ||
@pull_request ||= Changeset::PullRequest.find(repo, data['number']) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover from when the
changeset_from_webhook
was making a github api call. thanks.