Merge pull request #78 from juank-pa/jpazmino/fix_get_ticket_form_id_…

…overflow Fix get ticket form is overflow issue
zendesk · Jun 18, 2018 · 17b0abf · 17b0abf
2 parents 5548dab + 3816d20
commit 17b0abf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/android-plugin/src/main/java/com/zendesk/unity/providers/RequestProvider.java b/android-plugin/src/main/java/com/zendesk/unity/providers/RequestProvider.java
@@ -88,7 +88,7 @@ public void addCommentWithAttachments(final String gameObjectName, String callba
                 new ZendeskUnityCallback<Comment>(gameObjectName, callbackId, "didRequestProviderAddCommentWithAttachments"));
     }
 
-    public void getTicketFormWithIds(final String gameObjectName, String callbackId, int[] ticketFormsIds, int formsCount){
+    public void getTicketFormWithIds(final String gameObjectName, String callbackId, long[] ticketFormsIds, int formsCount){
 
         Long[] result = new Long[formsCount];
         for (int i = 0; i < formsCount; i++) {

diff --git a/ios-plugin/src/ZendeskProviderRequest.m b/ios-plugin/src/ZendeskProviderRequest.m
@@ -65,13 +65,13 @@ void _zendeskRequestProviderAddComment(char * gameObjectName, char * callbackId,
               withCallback:callback];
 }
 
-void _zendeskRequestProviderGetTicketFormWithIds(char * gameObjectName, char * callbackId, int ticketFormsIds[], int formsCount) {
+void _zendeskRequestProviderGetTicketFormWithIds(char * gameObjectName, char * callbackId, int64_t ticketFormsIds[], int formsCount) {
     ZDKRequestProvider *provider = [ZDKRequestProvider new];
     ZDKDefCallback(NSArray<ZDKTicketForm*>*, [result toJSONString], "didRequestProviderGetTicketFormWithIds")
 
     NSMutableArray *formIds = @[].mutableCopy;
     for (int i = 0 ; i < formsCount ; i ++) {
-        [formIds addObject:[NSNumber numberWithInt:ticketFormsIds[i]]];
+        [formIds addObject:[NSNumber numberWithLongLong:ticketFormsIds[i]]];
     }
 
     [provider getTicketFormWithIds:formIds callback:callback];

diff --git a/unity-src/scripts/ZDKRequestProvider.cs b/unity-src/scripts/ZDKRequestProvider.cs
@@ -145,9 +145,9 @@ public class ZDKRequestProvider : ZDKBaseComponent {
 		/// </summary>
 		/// <param name="ticketForms">List of ticket form ids to get.</param>
 		/// <param name="callback">Callback that will deliver a List of Ticket Forms.</param>
-		public static void GetTicketForms(int[] ticketForms, Action<ArrayList,ZDKError> callback) {
+		public static void GetTicketForms(long[] ticketForms, Action<ArrayList,ZDKError> callback) {
 			if (ticketForms == null)
-				ticketForms = new int[0];
+				ticketForms = new long[0];
 			instance().Call("getTicketFormWithIds", callback, ticketForms, ticketForms.Length);
 		}
 
@@ -184,7 +184,7 @@ public class ZDKRequestProvider : ZDKBaseComponent {
 		[DllImport("__Internal")]
 		private static extern void _zendeskRequestProviderAddCommentWithAttachments(string gameObjectName, string callbackId, string comment, string requestId, string[] attachments, int attachmentsLength);
 		[DllImport("__Internal")]
-		private static extern void _zendeskRequestProviderGetTicketFormWithIds(string gameObjectName, string callbackId, int[] ticketFormsIds, int formsCount);
+		private static extern void _zendeskRequestProviderGetTicketFormWithIds(string gameObjectName, string callbackId, long[] ticketFormsIds, int formsCount);
 		[DllImport("__Internal")]
 		private static extern void _zendeskRequestProviderGetUpdatesForDevice(string gameObjectName, string callbackId);
 		[DllImport("__Internal")]