Extract code to a CheckCodeowners::CLI class #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
commented
Jan 28, 2023
bquorning
force-pushed
the
bquorning.cli
branch
from
dae4174
to
43f98c2
Compare
`bundle exec rspec` now runs in 3 seconds instead of 16 seconds.
bquorning
force-pushed
the
bquorning.cli
branch
from
43f98c2
to
6962370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing how slowly the specs were running, I decided to extract most of the code from main.rb into a
CLIclass.bundle exec rspecnow runs in <3 seconds instead of >16 seconds.I am not too happy about the current state of the code. I think
root_pathis being passed around too much, and perhaps I shouldn’t insist on it being aPathnameinstance. Setting this PR as draft for now.