Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API's grandiose exception handling problem! #59

Closed
shehi opened this issue Dec 16, 2014 · 2 comments
Closed

API's grandiose exception handling problem! #59

shehi opened this issue Dec 16, 2014 · 2 comments

Comments

@shehi
Copy link

shehi commented Dec 16, 2014

Please revamp whole exception handling of the API so that every status code for exception cases are reflected correctly. E.g. instead of having one ResponseException let's have separate exceptions such as TooManyConnectionsException, MissingParameterException etc (and of course have unit-test-case for each exception handled). For every single status code at least. In it's current case, there is no way of managing the flow of code-logic, based upon the result's status code. E.g., it would be awesome to know before hand if one receives TooManyConnectionsException and upon the exception wait for necessary Retry-time seconds and try again.

With all due respect, this code needs very good peer-reviewing! It looks as if it was written for the sake of being written!

@ocke
Copy link
Contributor

ocke commented Jan 5, 2015

I couldn't agree more! 'Error' is not very helpful, and we ended up putting var_dump to see what the hell is going on.

@atroche
Copy link
Contributor

atroche commented May 31, 2015

Yeah, you guys are 100% right! We're looking at doing a pretty big rewrite at the moment, and one of our chief goals for that will be sane error handling. I'm going to close this issue out now, but trust me when I say that it's gonna get solved =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants