Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open call for feedback #89

Closed
atroche opened this issue May 31, 2015 · 6 comments
Closed

Open call for feedback #89

atroche opened this issue May 31, 2015 · 6 comments
Labels

Comments

@atroche
Copy link
Contributor

atroche commented May 31, 2015

Hey guys, I've cc'd everyone who's contributed to this repo recently.

@miogalang, @joseconsador and I are about to start a week-long intensive on this project in the Manila office. What do you think we should work on? I've identified a few things so far:

  • Better exception handling (thanks @shehi and @ocke)
  • Better unit test coverage (thanks @ggrossman)
  • Full support for all endpoints in the core API
  • Higher code quality in general (using static analysis, if possible)
  • A consistent interface for resources (i.e. the constructors, getters, setters, etc. should all work the same whether you're working with apps, tickets or anything else)
  • More information in the README about what the library can do, and how to use it

Anything else you'd like to mention? Now's a good time =)

@mtibben @jurajseffer @andreionut @bvarent @ha-quidco @miogalang @jwswj @mmolina

@atroche
Copy link
Contributor Author

atroche commented May 31, 2015

@patrickconroy
Copy link

It's really confusing that this API doesn't interact with the help_center API at all. For instance,

https://support.rockstargames.com/api/v2/help_center/categories/200013096.json
https://support.rockstargames.com/api/v2/categories/20107766.json

Will the v2 (branch) be able to interact with the help center as well as the core? Or should there be namespaces for Core and HelpCenter ? Otherwise I don't know how you'd reconcile the fact that Categories is valid in both.

@atroche
Copy link
Contributor Author

atroche commented Jun 29, 2015

Personally I think we should get v2 launched, and get the repo to a higher level of code quality + test coverage before we start adding in major new features. Especially seeing as the other Zendesk API clients don't support it yet.

@shehi
Copy link

shehi commented Jun 29, 2015

Agreed with @atroche : It'd be better to solve standing problems and then adding new features.

@jwswj
Copy link
Contributor

jwswj commented Jun 29, 2015

We're focusing on the initial core APIs first, but will provide a framework for Help Center, Voice & other endpoints through namespacing.

@jwswj
Copy link
Contributor

jwswj commented Jul 1, 2015

We've been making some great progress on the new version over the past week. Check out #99 if you're interested.

@jwswj jwswj closed this as completed Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants