Add helper methods for configuring Views #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ if defined?(RSpec) | |||
|
|
|||
| desc "Run live specs" | |||
| RSpec::Core::RakeTask.new("spec:live") do |t| | |||
| t.pattern = "spec/live/**/*_spec.rb" | |||
| t.pattern = "spec/live/**/view_spec.rb" | |||
There was a problem hiding this comment.
Should change this back to *_spec.rb
There was a problem hiding this comment.
You can always run a specific test like rspec spec/live/view_spec.rb
shanitang
force-pushed
the
ytang/rule-helper-methods
branch
from
2e0dbc1
to
e766759
Compare
write tests for #add_all_condition and #add_any_condition write tests for #all_conditions= and #any_conditions= write a test for #add_column update .gitignore
shanitang
force-pushed
the
ytang/rule-helper-methods
branch
from
542369e
to
5c29921
Compare
shanitang
force-pushed
the
ytang/rule-helper-methods
branch
from
3e48f62
to
22f44d6
Compare
shanitang
changed the title
shanitang
force-pushed
the
ytang/rule-helper-methods
branch
from
37a6f74
to
a4b243a
Compare
shanitang
force-pushed
the
ytang/rule-helper-methods
branch
from
a4b243a
to
0bb6c58
Compare
|
@steved555 @zendesk/archer |
| @@ -473,20 +506,39 @@ class View < Rule | |||
| has :execution, :class => RuleExecution | |||
| has ViewCount, :path => "count" | |||
|
|
|||
| def add_column(column) | |||
| columns = execution.columns.map {|c| c[:id]} | |||
There was a problem hiding this comment.
columns = execution.columns.map(&:id) is slightly shorter
shanitang
force-pushed
the
ytang/rule-helper-methods
branch
from
2e8c220
to
f8d0b5a
Compare
|
@steved555 |
| @@ -20,4 +20,78 @@ def valid_attributes | |||
| "all" => [{ "field" => "status", "operator" => "is", "value" => "pending" }] | |||
| } | |||
| it_should_be_deletable | |||
|
|
|||
| subject do | |||
| described_class.new(double, { | |||
There was a problem hiding this comment.
Could you use valid_attributes for this?
There was a problem hiding this comment.
Also, since live specs aren't run under travis it'd be really cool if we added a new spec/resources or add these under spec/core
shanitang
force-pushed
the
ytang/rule-helper-methods
branch
3 times, most recently
from
a04fa37
to
5ce06e0
Compare
shanitang
force-pushed
the
ytang/rule-helper-methods
branch
from
5ce06e0
to
350d0f2
Compare
|
@steved555 |
|
👍 from me |
|
👍 Thanks for sticking with it |
shanitang
added a commit
that referenced
this pull request
Dec 13, 2014
Add helper methods for configuring Views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@steved555 @zendesk/archer
Write helper methods for View configuration, which includes assigning and updating "columns" and "conditions" arguments. Minitest for those methods are also written in view_spec.