Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RED-1886] Add more CBP endpoints #556

Merged
merged 1 commit into from
Aug 24, 2023
Merged

[RED-1886] Add more CBP endpoints #556

merged 1 commit into from
Aug 24, 2023

Conversation

fbvilela
Copy link
Contributor

Description

Adds a few more endpoints to the list of supported CBP

Risk

  • low

@fbvilela fbvilela requested a review from a team as a code owner August 22, 2023 23:39
khezam
khezam approved these changes Aug 23, 2023
View reviewed changes
Copy link

@khezam khezam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍 💯 A small optional suggestion: It might be more consistent to keep class methods in class << self or self.method_name.

ecoologic
ecoologic approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@ecoologic ecoologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ - I'd love it if we had a link to the api doc for every regex. But no biggie.

Good job on the shared examples 👍

@fbvilela fbvilela merged commit 3703ca5 into master Aug 24, 2023
7 checks passed
@fbvilela fbvilela deleted the fvilela/add_cbp_endpoints branch August 24, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecoologic ecoologic ecoologic approved these changes

@khezam khezam khezam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbvilela @ecoologic @khezam