warn and set to UTF-8 as early as possible #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in powershell on windows 10, seems good |
fvzzy
approved these changes
Feb 17, 2017
shajith
pushed a commit
that referenced
this pull request
May 9, 2019
warn and set to UTF-8 as early as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Point people in the right direction to avoid encoding dramas.
Hard to give more specific instructions though - they depend on the platform, shell and how long-lived they want the change to be.
We shouldn't set this variable on a user's behalf either, both because it may clobber an encoding they intentionally and it may overwrite other settings in
RUBYOPT.cc @zendesk/vegemite
References
https://support.zendesk.com/hc/en-us/community/posts/203461336-Problems-with-accents-in-templates-
Risks