Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): migrate react-grid to storybook #1047

Merged
merged 2 commits into from
Mar 18, 2021
Merged

chore(docs): migrate react-grid to storybook #1047

merged 2 commits into from
Mar 18, 2021

Conversation

hzhu
Copy link
Contributor

@hzhu hzhu commented Mar 17, 2021 •
edited
Loading

Description

This PR migrates the react-grid package to Storybook.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@hzhu hzhu self-assigned this Mar 17, 2021
@zendesk-garden zendesk-garden temporarily deployed to staging March 17, 2021 21:54 Inactive
@zendesk-garden zendesk-garden temporarily deployed to staging March 18, 2021 18:55 Inactive
@hzhu hzhu marked this pull request as ready for review March 18, 2021 19:02
@hzhu hzhu requested a review from a team as a code owner March 18, 2021 19:02
jzempel
jzempel requested changes Mar 18, 2021
View reviewed changes
packages/grid/stories/examples/Default.tsx Outdated
Comment on lines 44 to 46
<Grid>
<Row>
<Col size="8">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me except for this surrounding Grid which should be removed so we can observe how the grid behaves across various screen sizes.

austingreendev
austingreendev approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@austingreendev austingreendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending @jzempel's changes

@hzhu hzhu requested a review from jzempel March 18, 2021 20:06
@zendesk-garden zendesk-garden temporarily deployed to staging March 18, 2021 20:23 Inactive
@hzhu hzhu merged commit 14a9ad0 into main Mar 18, 2021
@hzhu hzhu deleted the hzhu/grid-storybook branch March 18, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@austingreendev austingreendev austingreendev approved these changes

Assignees

@hzhu hzhu

Labels
PR: Docs 📝
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hzhu @jzempel @austingreendev @zendesk-garden