fix(build): ensure nested external dependencies are not bundled #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geotrev
reviewed
Jul 7, 2023
| */ | ||
| external: id => externalPackages.includes(id), | ||
| external: id => externalPackages.filter(regexp => regexp.test(id)).length > 0, |
There was a problem hiding this comment.
Is it valid for the value of external to be switched from a boolean return value to a filtered array? Just making sure.
There was a problem hiding this comment.
Actually we still return a boolean (notice the end of line 47 ....length > 0,) using a greater than 0 expression.
jzempel
approved these changes
Jul 7, 2023
Francois-Esquire
changed the title
geotrev
approved these changes
Jul 7, 2023
Francois-Esquire
deleted the
mike/chore/ensure-dependencies-are-not-bundled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that
dependenciesfor packages are not bundled into the distributable for our component packages. This reduces code duplication and limits multiple instances of a given library (egdate-fns) which can lead to unintended issues.Detail
This affects any component package that uses a nested import path.
Three packages have been affected:
chrome:dom-helpersnested import ofdom-helpers/activeElementdatepickers:date-fnsnested imports of various utilitiesmodals:dom-helpersnested import ofdom-helpers/activeElementChecklist
design updates will be Garden Designer approved (add the designer as a reviewer)demo is up-to-date (yarn start)renders as expected with reversed (RTL) directionrenders as expected with Bedrock CSS (?bedrock)includes new unit tests. Maintain existing coverage (always >= 96%)tested for WCAG 2.1 AA accessibility compliancetested in Chrome, Firefox, Safari, and Edge