Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox): stabilize production SSR ID generation #1618

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix(combobox): stabilize production SSR ID generation #1618

merged 1 commit into from
Sep 6, 2023

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Sep 5, 2023

Description

Fix ID mismatch with Combobox when rendered in production SSR environments

@jzempel jzempel requested a review from a team as a code owner September 5, 2023 19:42
geotrev
geotrev approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell the IDs look good. 👍🏻

@smritimadan
Copy link
Contributor

Looks good in the deployment 👍 !
Do we need additional tests to prevent in the future?

@jzempel
Copy link
Member Author

jzempel commented Sep 6, 2023

Do we need additional tests to prevent in the future?

@smritimadan at this time, I'm not able to identify a straightforward test that reliably reproduces and checks the issue

@jzempel jzempel merged commit 8fe3b9d into main Sep 6, 2023
6 checks passed
@jzempel jzempel deleted the jzempel/bump-combobox branch September 6, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geotrev geotrev geotrev approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jzempel @smritimadan @geotrev @zendesk-garden