-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allows menu to position correctly in RTL #1728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the direction
approach as the current Button
(and legacy Menu
) don't use that. Instead, the Garden-to-Popper placement logic needs refinement for RTL.
4b88764
to
ce407db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Please update this PR's description accordingly.
Description
Configures RTl override in Floating UI (FUI).
Detail
FUI determines RTL from
direction: rtl
in the style cascade. This PR sets an override to theplatform
utility function that now points totheme.rtl
.Checklist
👌 design updates will be Garden Designer approved (add the designer as a reviewer)npm start
)?bedrock
)💂♂️ includes new unit tests. Maintain existing coverage (always >= 96%)