Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows menu to position correctly in RTL #1728

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

geotrev
Copy link
Contributor

@geotrev geotrev commented Feb 29, 2024

Description

Configures RTl override in Floating UI (FUI).

Detail

FUI determines RTL from direction: rtl in the style cascade. This PR sets an override to the platform utility function that now points to theme.rtl.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@geotrev geotrev self-assigned this Feb 29, 2024
@geotrev geotrev requested a review from a team as a code owner February 29, 2024 15:42
@coveralls
Copy link

coveralls commented Feb 29, 2024

Coverage Status

coverage: 96.194%. remained the same
when pulling 1b374f1 on george/menu-rtl
into 1f19180 on main.

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want the direction approach as the current Button (and legacy Menu) don't use that. Instead, the Garden-to-Popper placement logic needs refinement for RTL.

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Please update this PR's description accordingly.

@geotrev geotrev merged commit 3e3be91 into main Mar 4, 2024
5 checks passed
@geotrev geotrev deleted the george/menu-rtl branch March 4, 2024 15:20
geotrev added a commit that referenced this pull request Mar 4, 2024
geotrev added a commit that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants