-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lint): update eslint rules #645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there should be a new require-display-name
custom rule added for eslint
under /utils.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add displayName
to the .template
package.
d5bee65
to
add6771
Compare
There is a lot of complexity in determining whether a
Updated! 👍 |
Description
This PR is an audit of our existing ESLint rules. The only change is that we now require
displayName
s for all React components. This was disabled previously, but should be best practice for us going forward.Checklist
designer as a reviewer)
yarn start
)