Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(modals): update container dependencies #650

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

hzhu
Copy link
Contributor

@hzhu hzhu commented Feb 25, 2020

Description

This pull request updates the react-modal container dependencies so that modals can take advantage of the new restore focus feature which was added to container-focusjail.

Demo

The demo can be found here: https://modals-dep-update.netlify.com/modals/#examples. The keyboard focus is now restored upon closing the modal for three scenarios:

  1. When a user selects the "X" close button in the top corner of the modal.
  2. When a user presses the "Escape" key.
  3. When a user clicks the backdrop.

Checklist

  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@hzhu hzhu self-assigned this Feb 25, 2020
@hzhu hzhu marked this pull request as ready for review February 25, 2020 17:11
@hzhu hzhu requested a review from a team as a code owner February 25, 2020 17:11
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.977% when pulling 2ad4705 on hzhu/update-modal-container-dep into 03122a3 on master.

@hzhu hzhu merged commit 0ed8f4f into master Feb 25, 2020
@hzhu hzhu deleted the hzhu/update-modal-container-dep branch February 25, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants