Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifications): add support for regular weight title #788

Merged
merged 1 commit into from
Jun 30, 2020
Merged

feat(notifications): add support for regular weight title #788

merged 1 commit into from
Jun 30, 2020

Conversation

hzhu
Copy link
Contributor

@hzhu hzhu commented Jun 29, 2020 •
edited

Description

Add the ability to show a Notification's title in regular font-weight.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@hzhu hzhu self-assigned this Jun 29, 2020
@hzhu hzhu marked this pull request as ready for review June 30, 2020 00:24
@hzhu hzhu requested a review from a team as a code owner June 30, 2020 00:24
@hzhu hzhu requested a review from ginnywood June 30, 2020 00:25
@coveralls
Copy link

Coverage Status

Coverage increased (+1.08%) to 97.692% when pulling 7e24b1a on hzhu/notification-title into 04ebfb9 on master.

@zendesk-garden zendesk-garden temporarily deployed to staging June 30, 2020 00:57 Inactive
@hzhu hzhu merged commit 8bf1276 into master Jun 30, 2020
@hzhu hzhu deleted the hzhu/notification-title branch June 30, 2020 20:34
@jzempel jzempel changed the title fix(notifications): add support for regular weight title feat(notifications): add support for regular weight title Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@austingreendev austingreendev austingreendev approved these changes

@ginnywood ginnywood ginnywood approved these changes

Assignees

@hzhu hzhu

Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hzhu @coveralls @jzempel @austingreendev @ginnywood @zendesk-garden