Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theming): provide scoping <div> knock-out for ThemeProvider #897

Merged
merged 4 commits into from
Oct 16, 2020

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Oct 16, 2020

Description

Items of note for this PR:

  • Adds support for focusVisibleRef={null} to prevent render of :focus-visible scoping div default
  • Adds associated spec tests
  • Fills out ThemeProvider prop documentation in prep for website.
  • Restores ThemeProvider prop sheet to the example page

Checklist

  • πŸ‘Œ design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🀘 renders as expected with Bedrock CSS (?bedrock)
  • β™Ώ analyzed via axe and evaluated using VoiceOver
  • πŸ’‚β€β™‚οΈ includes new unit tests
  • πŸ“ tested in Chrome, Firefox, Safari, Edge, and IE11

* [`ThemeProvider`](https://styled-components.com/docs/api#themeprovider)
* for details.
*/
theme?: DefaultTheme;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repeats the definition from the extended interface. But without it, we aren't able to document the prop. Therefore, I think it's imperative in this one case to make an exception and include it.

@zendesk-garden zendesk-garden temporarily deployed to staging October 16, 2020 17:24 Inactive
@jzempel jzempel merged commit 28909c0 into main Oct 16, 2020
@jzempel jzempel deleted the jzempel/themprovider-docs branch October 16, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants