Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utilities): migrate container-utilities to TypeScript #103

Merged
merged 4 commits into from
Sep 19, 2019
Merged

feat(utilities): migrate container-utilities to TypeScript #103

merged 4 commits into from
Sep 19, 2019

Conversation

austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Sep 18, 2019 •
edited
Loading

Description

This PR enables TypeScript support in the react-containers repository. All of the build/lint/testing logic has been lifted from the react-components repository and aligns with those standards.

As a proof-of-concept for the new build steps I have converted the container-utilities package to TS within this PR.

Detail

The first commit is limited to the TS build and configuration with the second commit containing the migration of container-utilities. I have also included the new useCombinedRefs hook from zendeskgarden/react-components#459

Checklist

  • 🌐 Storybook demo is up-to-date (yarn start)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested a review from a team September 18, 2019 23:54
jzempel
jzempel requested changes Sep 19, 2019
View reviewed changes
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint:js script needs to be updated with --ext js,ts,tsx

utils/build/declarations.d.ts Show resolved Hide resolved
@austingreendev
Copy link
Contributor Author

lint:js script needs to be updated with --ext js,ts,tsx

I also forgot to add the format:ts command. I've compared against the react-components commands and we are now at parity.

hzhu
hzhu approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@hzhu hzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jzempel
jzempel approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@austingreendev austingreendev merged commit 16583f4 into master Sep 19, 2019
@austingreendev austingreendev deleted the agreen/typescript branch September 19, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@hzhu hzhu hzhu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austingreendev @jzempel @hzhu