Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

The ->getAdapter() method does not set the adapter if passed in config o... #16

Closed

Conversation

lorenzoferrarajr
Copy link

This push relates to this issue zendframework/ZendService_Twitter#18

->getAdapter() method of parent class ZendOAuth\Client is:

public function getAdapter()
{
    if (! $this->adapter) {
        $this->setAdapter($this->config['adapter']);
    }

    return $this->adapter;
}

but here was:

public function getAdapter()
{
    return $this->adapter;
}

replaced with:

public function getAdapter()
{
    return parent::getAdapter();
}

…g options

`->getAdapter()` method of parent class `ZendOAuth\Client` is:

    public function getAdapter()
    {
        if (! $this->adapter) {
            $this->setAdapter($this->config['adapter']);
        }

        return $this->adapter;
    }

but here was:

    public function getAdapter()
    {
        return $this->adapter;
    }

replaced with:

    public function getAdapter()
    {
        return parent::getAdapter();
    }
@Maks3w
Copy link
Member

Maks3w commented Dec 2, 2013

Thank you @lorenzoferrarajr But this issue is duplicated with #13, #14 and #15. Also override the method for just call to parent makes unnecessary override the method.

@Maks3w Maks3w closed this Dec 2, 2013
@gbili
Copy link

gbili commented Apr 25, 2014

Any updates? When will ZendOAuth\Client::getAdapter() method be deleted?

@internalsystemerror
Copy link

The fix has already been applied in #14. A release needs to be tagged to fix everyones issue. In the meantime, we'll all have to use dev-master for zendoauth.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants