New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ->getAdapter() method does not set the adapter if passed in config o... #16

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@lorenzoferrarajr
Copy link

lorenzoferrarajr commented Nov 27, 2013

This push relates to this issue zendframework/ZendService_Twitter#18

->getAdapter() method of parent class ZendOAuth\Client is:

public function getAdapter()
{
    if (! $this->adapter) {
        $this->setAdapter($this->config['adapter']);
    }

    return $this->adapter;
}

but here was:

public function getAdapter()
{
    return $this->adapter;
}

replaced with:

public function getAdapter()
{
    return parent::getAdapter();
}
The ->getAdapter() method does not set the adapter if passed in confi…
…g options

`->getAdapter()` method of parent class `ZendOAuth\Client` is:

    public function getAdapter()
    {
        if (! $this->adapter) {
            $this->setAdapter($this->config['adapter']);
        }

        return $this->adapter;
    }

but here was:

    public function getAdapter()
    {
        return $this->adapter;
    }

replaced with:

    public function getAdapter()
    {
        return parent::getAdapter();
    }
@Maks3w

This comment has been minimized.

Copy link
Member

Maks3w commented Dec 2, 2013

Thank you @lorenzoferrarajr But this issue is duplicated with #13, #14 and #15. Also override the method for just call to parent makes unnecessary override the method.

@Maks3w Maks3w closed this Dec 2, 2013

@gbili

This comment has been minimized.

Copy link

gbili commented Apr 25, 2014

Any updates? When will ZendOAuth\Client::getAdapter() method be deleted?

@internalsystemerror

This comment has been minimized.

Copy link

internalsystemerror commented May 12, 2014

The fix has already been applied in #14. A release needs to be tagged to fix everyones issue. In the meantime, we'll all have to use dev-master for zendoauth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment