Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

tag online tests to be able to easily skip them #12

Merged
merged 1 commit into from
May 8, 2018

Conversation

remicollet
Copy link
Contributor

When running test suite without internet connection:

There were 2 errors:

1) ZendServiceTest\ReCaptcha\ReCaptchaTest::testVerifyWithMissingChallengeField
Zend\Http\Client\Adapter\Exception\RuntimeException: Error in cURL request: Could not resolve host: www.google.com

/work/GIT/ZendService_ReCaptcha/vendor/zendframework/zend-http/src/Client/Adapter/Curl.php:458
/work/GIT/ZendService_ReCaptcha/vendor/zendframework/zend-http/src/Client.php:1425
/work/GIT/ZendService_ReCaptcha/vendor/zendframework/zend-http/src/Client.php:923
/work/GIT/ZendService_ReCaptcha/src/ReCaptcha.php:465
/work/GIT/ZendService_ReCaptcha/src/ReCaptcha.php:479
/work/GIT/ZendService_ReCaptcha/test/ReCaptchaTest.php:281

2) ZendServiceTest\ReCaptcha\ReCaptchaTest::testVerifyWithMissingResponseField
Zend\Http\Client\Adapter\Exception\RuntimeException: Error in cURL request: Could not resolve host: www.google.com

/work/GIT/ZendService_ReCaptcha/vendor/zendframework/zend-http/src/Client/Adapter/Curl.php:458
/work/GIT/ZendService_ReCaptcha/vendor/zendframework/zend-http/src/Client.php:1425
/work/GIT/ZendService_ReCaptcha/vendor/zendframework/zend-http/src/Client.php:923
/work/GIT/ZendService_ReCaptcha/src/ReCaptcha.php:465
/work/GIT/ZendService_ReCaptcha/src/ReCaptcha.php:479
/work/GIT/ZendService_ReCaptcha/test/ReCaptchaTest.php:295

This simple fix allow to run phpunit --exclude online

Which will make downstream life easier ;)

@froschdesign
Copy link
Member

I think, a hint in the readme file would be good:

Installation

Testing

Documentation

@weierophinney weierophinney merged commit a72b6a3 into zendframework:master May 8, 2018
weierophinney added a commit that referenced this pull request May 8, 2018
weierophinney added a commit that referenced this pull request May 8, 2018
@weierophinney
Copy link
Member

Thanks, @remicollet.

@remicollet remicollet deleted the issue-dns branch May 14, 2018 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants