Skip to content
This repository has been archived by the owner on Jan 1, 2020. It is now read-only.

Alter DocumentRoot in 000-default.conf #361

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Alter DocumentRoot in 000-default.conf #361

merged 1 commit into from
Mar 11, 2017

Conversation

Forage
Copy link
Contributor

@Forage Forage commented Jul 8, 2016

There's no /var/www/html text to be replaced in the default /etc/apache2/apache2.conf file.
This change will alter the same file as the Vagrant config.

There's no `/var/www/html` text to be replaced in the default `/etc/apache2/apache2.conf` file.
This change will alter the same file as the Vagrant config.
@weierophinney
Copy link
Member

Have you experienced an actual issue here?

The php:7.0-apache image has an apache2.conf file that differs from the one normally installed by Debian/Ubuntu, and which contains a DocumentRoot entry for the default vhost; the configuration we're using here in the Dockerfile updates that entry specifically.

As a test, I just did the following:

  • Cloned the repository to a new directory
  • Ran composer install
  • Ran composer development-enable
  • Ran docker-compose build
  • Ran docker-compose up
  • Visited localhost:8080

All worked as expected, and I was able to see that apache was accepting and responding to my requests.

@jasonsemko
Copy link

Can we please get this merged in?

I used:

composer create-project zendframework/skeleton-application test-zend-apache

To install, get 404s unless I do this fix.

@michalbundyra
Copy link
Member

I think the issue is valid.
@weierophinney please check your local docker images:

$ docker images

and try update it to the latest version:

$ docker pull php:7.0-apache

For more information please check my comment zfcampus/zf-apigility-skeleton#150 (comment).

@michaellenahan
Copy link

I needed this patch today to get the docker container to work.

Without the patch:

docker-compose down
docker-compose build
docker-compose up

http://localhost:8080/

Not Found
The requested URL / was not found on this server.
Apache/2.4.10 (Debian) Server at localhost Port 8080

With the patch:

docker-compose down
docker-compose build
docker-compose up

http://localhost:8080/
... The Skeleton Application is served.

@Xerkus
Copy link
Member

Xerkus commented Mar 11, 2017

Confirmed

@Xerkus Xerkus merged commit 0c5310f into zendframework:master Mar 11, 2017
Xerkus added a commit that referenced this pull request Mar 11, 2017
@Xerkus Xerkus added this to the 3.0.2 milestone Mar 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants