This repository has been archived by the owner on Jan 1, 2020. It is now read-only.
Added env check and changed glob line #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and changed the glob line for config files
| $appConfig = include 'config/application.config.php'; | ||
|
|
||
| $listenerOptions = new Zend\Module\Listener\ListenerOptions($appConfig['module_listener_options']); | ||
| $defaultListeners = new Zend\Module\Listener\DefaultListenerAggregate($listenerOptions); | ||
| $defaultListeners->getConfigListener()->addConfigGlobPath('config/autoload/*.config.php'); | ||
| $defaultListeners->getConfigListener()->addConfigGlobPath("config/autoload/*.{global,$env}.php"); |
There was a problem hiding this comment.
To keep or not to keep .config.php?
There was a problem hiding this comment.
Fixed it to be {global,$env}.config.php now
| $appConfig = include 'config/application.config.php'; | ||
|
|
||
| $listenerOptions = new Zend\Module\Listener\ListenerOptions($appConfig['module_listener_options']); | ||
| $defaultListeners = new Zend\Module\Listener\DefaultListenerAggregate($listenerOptions); | ||
| $defaultListeners->getConfigListener()->addConfigGlobPath('config/autoload/*.config.php'); | ||
| $defaultListeners->getConfigListener()->addConfigGlobPath("config/autoload/*.{global,$env}..configphp"); |
There was a problem hiding this comment.
Shouldn't this be *{global,$env}.config.php ?
There was a problem hiding this comment.
Yeh I noticed my mess up after going to bed and tried to fix it on my phone, which ended in disaster. Should be sorted now.
|
@Ocramius the commits could probably be squashed into 1 so you only see the final |
|
Why worry? It doesn't really hurt. Though you could probably squash. |
…o facilitate local changes pulled in by index.php glob config
EvanDotPro
added a commit
that referenced
this pull request
Mar 6, 2012
Added env check and changed glob line
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added environment check for application_env and changed the glob line for config files