Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Move Coverage reporting to latest env #113

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Move Coverage reporting to latest env #113

merged 1 commit into from
Oct 26, 2016

Conversation

Koopzington
Copy link
Contributor

Requiring php-coveralls results in a full update of all dependencies instead of composer installing the versions mentioned in the composer.lock

Requiring php-coveralls results in a full update of all dependencies instead of composer installing the versions mentioned in the composer.lock
@marc-mabe
Copy link
Member

@Koopzington This will slow down the tests a lot as generating the code coverage and looking up the latest versions both takes additional time and should be spitted over different build jobs

@Koopzington
Copy link
Contributor Author

uhm... what would slow the tests down? It's not like i added some new feature, i merely moved the execution to the environment where it's supposed to be.
Build execution times haven't increased either compared to the one before this one:
https://travis-ci.org/zendframework/zend-cache/builds/159688399
https://travis-ci.org/zendframework/zend-cache/builds/152799417

@marc-mabe
Copy link
Member

@Koopzington Oh you are right - installing the latest dependencies only takes some seconds more than installing from lock. the biggest overhead comes from code coverage (~2mins more) but we have to do it at least once

@marc-mabe marc-mabe self-assigned this Oct 26, 2016
@marc-mabe marc-mabe merged commit d5ff193 into zendframework:master Oct 26, 2016
marc-mabe added a commit that referenced this pull request Oct 26, 2016
Move Coverage reporting to latest env
marc-mabe added a commit that referenced this pull request Oct 26, 2016
marc-mabe added a commit that referenced this pull request Oct 26, 2016
@Koopzington Koopzington deleted the move-coverage branch November 21, 2016 15:54
@marc-mabe marc-mabe added this to the 2.7.2 milestone Dec 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants