This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Deprecate capability "expiredRead" #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This capability does not make sense as it was previusly for informing that items if a storage adapter can be read if the TTL will be increased or set to infinity but this only works on storage adapters with capability "static_ttl" and increasing the TTL on the same time means that the item is no longer expired. So it's basically providing the same information as "static_ttl" but from a wrong PoV. The capability is now returning the information provided by "static_ttl" and will trigger a E_USER_DEPRECATED message.
marc-mabe
changed the title
marc-mabe
added a commit
that referenced
this pull request
Dec 16, 2016
Deprecate capability "expiredRead"
marc-mabe
added a commit
that referenced
this pull request
Dec 16, 2016
marc-mabe
added a commit
that referenced
this pull request
Dec 16, 2016
marc-mabe
added a commit
that referenced
this pull request
Dec 16, 2016
Conflicts: doc/book/storage/adapter.md src/Storage/Adapter/AbstractZendServer.php src/Storage/Capabilities.php test/Storage/Adapter/CommonAdapterTest.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #81
This capability does not make sense as it was previously for informing
that items of a storage adapter can be read if the TTL will be increased
or set to infinity but this only works on storage adapters with capability
static_ttland increasing the TTL on the same time means that the itemis no longer expired. So it's basically providing the same information as
static_ttlbut from a wrong PoV.The capability is now returning the information provided by
static_ttland will trigger a
E_USER_DEPRECATEDmessage.