This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
PHP 7.2 + QA Tools - follow up #129, #132, #134 #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added phpunit 6 support travis update (cherry picked from commit d80589a)
some new cache tests updated
Without that use statement, the check would always be false. See https://3v4l.org/#preview This was detected by etsy/phan, and the bug may or may not occur in real code. This change affects setFromArray() on line 315
phpunit update
Give php the absolute `use` path to Traversable
- added PHP 7.1 & PHP 7.2 - dropped HHVM - removed building docs
|
Thanks for working on that but please split into smaller PRs |
With version 2 package has been renamed from "satooshi/php-coveralls" to "php-coveralls/php-coveralls", and the script has been renamed from "coveralls" to "php-coveralls"
|
I don't know how to configure all these cache adapters on travis for all supported PHP versions... I was trying multiple times and still something is failing 😞 |
|
Sorry, closed by accident |
|
@webimpress Can you try to split this PR? It's very complicated to review and test it. |
|
@webimpress I tend to agree with @thomasvargiu , particularly as #132 is unrelated to QA tooling, and needs to be rewritten. I'll merge #129 for now, and then start working on a patch that incorporates the QA-related commits from this one. |
|
Closing in favor of #148, which incorporates commits from this patch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129
Closes #132
Closes #134
Resolves #139
/cc @froschdesign