Merge branch 'hotfix/37'

Close #38
Fixes #37

CHANGELOG.md

@@ -2,6 +2,28 @@
 
 All notable changes to this project will be documented in this file, in reverse chronological order by release.
 
+## 0.7.1 - 2017-04-11
+
+### Added
+
+- Nothing.
+
+### Deprecated
+
+- Nothing.
+
+### Removed
+
+- Nothing.
+
+### Fixed
+
+- [#38](https://github.com/zendframework/zend-component-installer/pull/38) fixes
+  an issue with detection of config providers in `ConfigAggregator`-based
+  configuration files. Previously, entries that were globally qualified
+  (prefixed with `\\`) were not properly detected, leading to the installer
+  re-asking to inject.
+
 ## 0.7.0 - 2017-02-22
 
 ### Added

src/Injector/ConfigAggregatorInjector.php

@@ -78,11 +78,14 @@ class ConfigAggregatorInjector extends AbstractInjector
      */
     public function __construct($projectRoot = '')
     {
+        $ns = preg_quote('\\');
         $this->isRegisteredPattern = '/new (?:'
-            . preg_quote('\\')
+            . $ns
             . '?'
             . preg_quote('Zend\ConfigAggregator\\')
-            . ')?ConfigAggregator\(\s*(?:array\(|\[).*\s+%s::class/s';
+            . ')?ConfigAggregator\(\s*(?:array\(|\[).*\s+'
+            . $ns
+            . '?%s::class/s';
 
         $this->injectionPatterns[self::TYPE_CONFIG_PROVIDER]['pattern'] = sprintf(
             "/(new (?:%s?%s)?ConfigAggregator\(\s*(?:array\(|\[)\s*)(?:\r|\n|\r\n)(\s*)/",

test/Injector/ConfigAggregatorInjectorTest.php

@@ -7,6 +7,7 @@
 
 namespace ZendTest\ComponentInstaller\Injector;
 
+use org\bovigo\vfs\vfsStream;
 use Zend\ComponentInstaller\Injector\ConfigAggregatorInjector;
 
 class ConfigAggregatorInjectorTest extends AbstractInjectorTestCase
@@ -151,4 +152,14 @@ public function packagePopulatedInConfiguration()
         ];
         // @codingStandardsIgnoreEnd
     }
+
+    public function testProperlyDetectsExistingConfigProviderInConfigWithMixedRelativeAndGloballyQualifiedNames()
+    {
+        $contents = file_get_contents(__DIR__ . '/TestAsset/expressive-application-from-skeleton.config.php');
+        vfsStream::newFile('config/config.php')
+            ->at($this->configDir)
+            ->setContent($contents);
+
+        $this->assertTrue($this->injector->isRegistered('Zend\Validator\ConfigProvider'));
+    }
 }

test/Injector/TestAsset/expressive-application-from-skeleton.config.php

@@ -0,0 +1,37 @@
+<?php
+
+use Zend\ConfigAggregator\ArrayProvider;
+use Zend\ConfigAggregator\ConfigAggregator;
+use Zend\ConfigAggregator\PhpFileProvider;
+
+// To enable or disable caching, set the `ConfigAggregator::ENABLE_CACHE` boolean in
+// `config/autoload/local.php`.
+$cacheConfig = [
+    'config_cache_path' => 'data/config-cache.php',
+];
+
+$aggregator = new ConfigAggregator([
+    \Zend\Validator\ConfigProvider::class,
+    \Zend\InputFilter\ConfigProvider::class,
+    \Zend\Filter\ConfigProvider::class,
+    \Zend\Mail\ConfigProvider::class,
+    \Contact\ConfigProvider::class,
+    // Include cache configuration
+    new ArrayProvider($cacheConfig),
+
+    // Default App module config
+    App\ConfigProvider::class,
+
+    // Load application config in a pre-defined order in such a way that local settings
+    // overwrite global settings. (Loaded as first to last):
+    //   - `global.php`
+    //   - `*.global.php`
+    //   - `local.php`
+    //   - `*.local.php`
+    new PhpFileProvider('config/autoload/{{,*.}global,{,*.}local}.php'),
+
+    // Load development config if it exists
+    new PhpFileProvider('config/development.config.php'),
+], $cacheConfig['config_cache_path']);
+
+return $aggregator->getMergedConfig();