This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Ensure we can detect globally qualified config providers #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes zendframework#37. Essentially, the `$isRegisteredPattern` was failing if the `$package` was globally qualified within the configuration (e.g., `\Zend\Validator\ConfigProvider`). The pattern now checks for an optional `\\` prefix to the FQCN.
weierophinney
added a commit
that referenced
this pull request
Apr 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #37. Essentially, the
$isRegisteredPatternwas failingif the
$packagewas globally qualified within the configuration (e.g.,\Zend\Validator\ConfigProvider). The pattern now checks for anoptional
\\prefix to the FQCN.