zendframework/zendframework#6646 - Removing dangerous internal mutabl…

…e state change (password kept in memory!)
zendframework · Jan 3, 2015 · edacb9b · edacb9b
1 parent 5f1d8d2
commit edacb9b
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/src/Prompt/Password.php b/src/Prompt/Password.php
@@ -21,11 +21,6 @@ final class Password extends AbstractPrompt
      */
     private $echo;
 
-    /**
-     * @var string
-     */
-    private $password = '';
-
     /**
      * Ask the user for a password
      *
@@ -51,6 +46,8 @@ public function show()
 
         $console->write($this->promptText);
 
+        $password = '';
+
         /**
          * Read characters from console
          */
@@ -65,9 +62,9 @@ public function show()
                 echo "*";
             }
 
-            $this->password .= $char;
+            $password .= $char;
         }
 
-        return $this->password;
+        return $password;
     }
 }