Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

removed getHelpers #380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

removed getHelpers #380

wants to merge 1 commit into from

Conversation

chris-kruining
Copy link

method remained unused for 7 years and is bugged, see #379
for details

methoid remained unused for 7 years and is bugged, see #379 for details
@chris-kruining
Copy link
Author

could someone merge?

@Xerkus Xerkus added this to the 3.0.0 milestone Jun 4, 2019
@Xerkus
Copy link
Member

Xerkus commented Jun 4, 2019

Even though it is not used, removal of a public method is a BC break. Since it causes no bugs or side effects it will be removed in next major.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#7.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-db to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-db.
  • In your clone of laminas/laminas-db, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants