This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Splitting StringResponse into HtmlResponse and JsonResponse #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
to weierophinney/zend-diactoros
that referenced
this pull request
Jun 24, 2015
- Per @moufmouf on zendframework#62, this patch adds some basic error handling to the `HtmlResponse` to ensure we have a either a string, or a StreamInterface instance, raising an InvalidArgumentException if not.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #61.
The
HtmlResponseandJsonResponseclasses mimics the behaviour of @weierophinney 'sRedirectResponseandEmptyResponse(i.e. they directly extend the Response class instead of providing a factory)Most of the JSON code for handling errors comes from Symfony's JsonResponse.
We could optionnally add a static
createmethod to create the response (a bit like Symfony does...)