Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Added vendor to travis cache #73

Merged
merged 2 commits into from
Jul 29, 2015

Conversation

weierophinney
Copy link
Member

@weierophinney
Copy link
Member Author

You can see the differences between the two builds:

HHVM does not benefit much from the change, but the other builds take around 50% less time overall, and the full time for all jobs dropped by a > 30%. Definitely worth it!

@mwillbanks mwillbanks added this to the 1.1.3 milestone Jul 29, 2015
@mwillbanks mwillbanks merged commit 5423b19 into zendframework:master Jul 29, 2015
mwillbanks added a commit that referenced this pull request Jul 29, 2015
mwillbanks added a commit that referenced this pull request Jul 29, 2015
mwillbanks added a commit that referenced this pull request Jul 29, 2015
@Maks3w
Copy link
Member

Maks3w commented Jul 29, 2015

  1. We need a way of print what depenency versions are used. At this moment we are blind on that.
  2. Take this other comparison
    https://travis-ci.org/zendframework/zend-diactoros/builds/70634633
    https://travis-ci.org/zendframework/zend-diactoros/builds/73250365

It's not fair compare against a cold cache

I suggest to fix 1 and don't propagate this across the whole repos until we can verify how works when new versions are released

@weierophinney
Copy link
Member Author

@Maks3w (1) can be fixed as easily as adding this as a before_script:

- composer info -i

Regarding (2), I honestly don't understand why the 1.1.2 release built so quickly; most of the other builds I've seen have been closer to the original build of this PR.

I'll get a PR in place with the composer info -i change.

@weierophinney weierophinney deleted the hotfix/vendor-cache branch July 29, 2015 20:30
weierophinney added a commit to weierophinney/zend-diactoros that referenced this pull request Jul 29, 2015
Per comment from @Maks3w on zendframework#73, this adds an `install` script to print the
installed dependencies.
@Maks3w
Copy link
Member

Maks3w commented Jul 29, 2015

Travis runs faster in the morning (Europe) night (America) because the anonymous rate limit against GitHub API is not so exhausted.

If Composer can install using dist version (not clone) then the dependency can be sucesfully saved in the cache

IMO we have a very good decent speed rate. I hope Composer will improve the work with Travis-CI cache without the need of this kind of workarounds

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants