This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
[WIP] make more Symfony2 console friendly, make runner more flexible #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $color = Color::RED; | ||
| } elseif ($result instanceof Warning) { | ||
| $color = Color::YELLOW; | ||
| } elseif ($result instanceof Success) { |
There was a problem hiding this comment.
interfaces should be used here instead of implementations
require php 5.3.3, set a branch alias for 2.0.x, do not require phpunit
…erbose (output) flag
|
#12 .. untested .. hoping to have some time next week again for this .. but no guarantees. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put these together not because they logically fit together but since I am using this more as a play ground for things I am testing out.
it includes #9 and #10
relevant commits:
Symfony console friendliness
356fce5
see also https://github.com/liip/LiipMonitorBundle/pull/33/files#L7R24
making it possible to run individual checks
c11ab6a
see also https://github.com/liip/LiipMonitorBundle/pull/33/files#L4R41