This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
some minor CS and code tweaks #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh cool. I see you've also put |
| use ZendDiagnostics\Result\SuccessInterface; | ||
| use ZendDiagnostics\Result\WarningInterface; | ||
| use ZendDiagnostics\Result\FailureInterface; | ||
| use ZendDiagnostics\Result\ResultInterface; |
There was a problem hiding this comment.
Thanks for those - I was refactoring ZFTool's classes and it seems that I've missed this in some places...
|
i added that later, same for the phpunit.xml which is why i didnt mention it in the description. |
|
We already have it in master https://github.com/zendframework/ZendDiagnostics/blob/master/tests/phpunit.xml.dist |
require php 5.3.3, set a branch alias for 2.0.x, do not require phpunit
|
removed that file |
|
Meh too many conflicts right now.. you seem to have fixed some things that you've already commented on,,, |
|
I'll merge it manually... |
|
i can also handle the rebase of this branch for you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.