Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Commit

Permalink
Merge branch 'hotfix/geteventmanager' of https://github.com/akrabat/zf2
Browse files Browse the repository at this point in the history
… into feature/eventmanager-getter
  • Loading branch information
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion src/EventsCapableInterface.php
Expand Up @@ -37,5 +37,5 @@ interface EventsCapableInterface
*
* @return EventManagerInterface
*/
public function events();
public function getEventManager();
}
2 changes: 1 addition & 1 deletion src/ProvidesEvents.php
Expand Up @@ -69,7 +69,7 @@ public function setEventManager(EventManagerInterface $events)
*
* @return EventManagerInterface
*/
public function events()
public function getEventManager()
{
if (!$this->events instanceof EventManagerInterface) {
$this->setEventManager(new EventManager());
Expand Down
24 changes: 12 additions & 12 deletions test/StaticIntegrationTest.php
Expand Up @@ -52,7 +52,7 @@ function ($e) use ($counter) {
}
);
$class = new TestAsset\ClassWithEvents();
$class->events()->setSharedManager($events);
$class->getEventManager()->setSharedManager($events);
$class->foo();
$this->assertEquals(1, $counter->count);
}
Expand All @@ -69,10 +69,10 @@ function ($e) use ($test) {
}
);
$class = new TestAsset\ClassWithEvents();
$class->events()->attach('foo', function ($e) use ($test) {
$class->getEventManager()->attach('foo', function ($e) use ($test) {
$test->results[] = 'local';
});
$class->events()->setSharedManager($events);
$class->getEventManager()->setSharedManager($events);
$class->foo();
$this->assertEquals(array('local', 'static'), $test->results);
}
Expand All @@ -90,16 +90,16 @@ function ($e) use ($test) {
10000 // high priority
);
$class = new TestAsset\ClassWithEvents();
$class->events()->attach('foo', function ($e) use ($test) {
$class->getEventManager()->attach('foo', function ($e) use ($test) {
$test->results[] = 'local';
}, 1); // low priority
$class->events()->attach('foo', function ($e) use ($test) {
$class->getEventManager()->attach('foo', function ($e) use ($test) {
$test->results[] = 'local2';
}, 1000); // medium priority
$class->events()->attach('foo', function ($e) use ($test) {
$class->getEventManager()->attach('foo', function ($e) use ($test) {
$test->results[] = 'local3';
}, 15000); // highest priority
$class->events()->setSharedManager($events);
$class->getEventManager()->setSharedManager($events);
$class->foo();
$this->assertEquals(array('local3', 'static', 'local2', 'local'), $test->results);
}
Expand All @@ -115,7 +115,7 @@ function ($e) use ($counter) {
}
);
$class = new TestAsset\ClassWithEvents();
$class->events()->unsetSharedManager();
$class->getEventManager()->unsetSharedManager();
$class->foo();
$this->assertEquals(0, $counter->count);
}
Expand All @@ -132,8 +132,8 @@ function ($e) use ($counter) {
);
$mockStaticEvents = new TestAsset\StaticEventsMock();
$class = new TestAsset\ClassWithEvents();
$class->events()->setSharedManager($mockStaticEvents);
$this->assertSame($mockStaticEvents, $class->events()->getSharedManager());
$class->getEventManager()->setSharedManager($mockStaticEvents);
$this->assertSame($mockStaticEvents, $class->getEventManager()->getSharedManager());
$class->foo();
$this->assertEquals(0, $counter->count);
}
Expand All @@ -151,10 +151,10 @@ function ($e) use ($test) {
100
);
$class = new TestAsset\ClassWithEvents();
$class->events()->attach('foo', function ($e) use ($test) {
$class->getEventManager()->attach('foo', function ($e) use ($test) {
$test->results[] = 'local';
}, -100);
$class->events()->setSharedManager($events);
$class->getEventManager()->setSharedManager($events);
$class->foo();
$this->assertEquals(array('static', 'local'), $test->results);
}
Expand Down
4 changes: 2 additions & 2 deletions test/TestAsset/ClassWithEvents.php
Expand Up @@ -36,7 +36,7 @@ class ClassWithEvents
{
protected $events;

public function events(EventManagerInterface $events = null)
public function getEventManager(EventManagerInterface $events = null)
{
if (null !== $events) {
$this->events = $events;
Expand All @@ -49,6 +49,6 @@ public function events(EventManagerInterface $events = null)

public function foo()
{
$this->events()->trigger(__FUNCTION__, $this, array());
$this->getEventManager()->trigger(__FUNCTION__, $this, array());
}
}

0 comments on commit db33b2e

Please sign in to comment.