Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Write keys to parent app data dir if available #37

Merged
merged 5 commits into from Apr 4, 2018

Conversation

marcguyer
Copy link
Contributor

* Addresses zendframework#35
* Create a data/oauth subdir for organization
* Added error handling for, among other things, openssl ext availability
* Convert to "bin" per zendframework#3 so parent app can run `composer zend-expressive-authentication-oauth2-generate-keys`
@ezimuel
Copy link
Contributor

ezimuel commented Apr 4, 2018

@marcguyer thanks for this PR. Everything looks good to me. I've only one concern about the name of the script bin/zend-expressive-authentication-oauth2-generate-keys, it looks verbose. Why we cannot use a short name like bin/generate-oauth2-keys?

@marcguyer
Copy link
Contributor Author

I had a similar thought but decided to start with "most verbose" and see what you thought. I think it's best to use a convention of <package id prefix>-<script purpose> but I agree that the full package name as a prefix is probably overboard. How about ze-oauth2-generate-keys?

@ezimuel
Copy link
Contributor

ezimuel commented Apr 4, 2018

I think the most important point here is simplicity and usability. We can just use a name that reflects the action provided by the script. I would prefer generate-oauth2-keys. People can use this script also for oauth2.thephpleague.com. What do you think?

@marcguyer
Copy link
Contributor Author

Ok, I think we're all set.

@ezimuel ezimuel merged commit 5f0e718 into zendframework:master Apr 4, 2018
@ezimuel
Copy link
Contributor

ezimuel commented Apr 4, 2018

@marcguyer thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants