This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
"bin" or "scripts" for bin/generate-keys.php? #3
Comments
2 tasks
marcguyer
added a commit
to chdr/zend-expressive-authentication-oauth2
that referenced
this issue
Mar 26, 2018
* Create a data/oauth subdir for organization * Added error handling for, among other things, openssl ext availability * Close zendframework#35 * Convert to "bin" per zendframework#3 so parent app can run `composer zend-expressive-authentication-oauth2-generate-keys`
marcguyer
added a commit
to chdr/zend-expressive-authentication-oauth2
that referenced
this issue
Mar 26, 2018
* Create a data/oauth subdir for organization * Added error handling for, among other things, openssl ext availability * Convert to "bin" per zendframework#3 so parent app can run `composer zend-expressive-authentication-oauth2-generate-keys`
marcguyer
added a commit
to chdr/zend-expressive-authentication-oauth2
that referenced
this issue
Mar 26, 2018
* Addresses zendframework#35 * Create a data/oauth subdir for organization * Added error handling for, among other things, openssl ext availability * Convert to "bin" per zendframework#3 so parent app can run `composer zend-expressive-authentication-oauth2-generate-keys`
The fix is provided in #37 which is merged but not yet released, so I'm leaving this open until release. |
Just released in 1.0.0alpha5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Should we have script
bin/generate-keys.php
inbin
orscripts
section incomposer.json
?I think it should be in
bin
, and currently it is inscripts
. If we have it in bin then will be available when we install package via composer invendor/bin/...
. When it is inscripts
it is only available in that package.When we change it to
bin
maybe we should also use another name, because this could be too generic, something withzend-
/zf-
maybe?The text was updated successfully, but these errors were encountered: