Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

"bin" or "scripts" for bin/generate-keys.php? #3

Closed
michalbundyra opened this issue Nov 21, 2017 · 2 comments
Closed

"bin" or "scripts" for bin/generate-keys.php? #3

michalbundyra opened this issue Nov 21, 2017 · 2 comments

Comments

@michalbundyra
Copy link
Member

Should we have script bin/generate-keys.php in bin or scripts section in composer.json?

I think it should be in bin, and currently it is in scripts. If we have it in bin then will be available when we install package via composer in vendor/bin/.... When it is in scripts it is only available in that package.
When we change it to bin maybe we should also use another name, because this could be too generic, something with zend-/zf- maybe?

marcguyer added a commit to chdr/zend-expressive-authentication-oauth2 that referenced this issue Mar 26, 2018
* Create a data/oauth subdir for organization
* Added error handling for, among other things, openssl ext availability
* Close zendframework#35
* Convert to "bin" per zendframework#3 so parent app can run `composer zend-expressive-authentication-oauth2-generate-keys`
marcguyer added a commit to chdr/zend-expressive-authentication-oauth2 that referenced this issue Mar 26, 2018
* Create a data/oauth subdir for organization
* Added error handling for, among other things, openssl ext availability
* Convert to "bin" per zendframework#3 so parent app can run `composer zend-expressive-authentication-oauth2-generate-keys`
marcguyer added a commit to chdr/zend-expressive-authentication-oauth2 that referenced this issue Mar 26, 2018
* Addresses zendframework#35
* Create a data/oauth subdir for organization
* Added error handling for, among other things, openssl ext availability
* Convert to "bin" per zendframework#3 so parent app can run `composer zend-expressive-authentication-oauth2-generate-keys`
@michalbundyra
Copy link
Member Author

The fix is provided in #37 which is merged but not yet released, so I'm leaving this open until release.

@ezimuel
Copy link
Contributor

ezimuel commented May 7, 2018

Just released in 1.0.0alpha5

@ezimuel ezimuel closed this as completed May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants