This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Update dependencies #235
Merged
Update dependencies #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geerteltink
approved these changes
Mar 7, 2018
| @@ -46,12 +46,14 @@ | |||
| $app->pipe(PathBasedRoutingMiddleware::class); | |||
There was a problem hiding this comment.
Maybe we can explain here that at this point the RouteResult::class is injected. It took me 20 minutes yesterday to figure out why a middleware wasn't working :)
This patch updates the skeleton to use zend-expressive-router 3.0.0rc4, as well as the compatible versions of each of the existing adapters. One change necessary is for the pipeline to change the order of the various zend-expressive-router middleare; `MethodNotAllowedMiddleware` MUST follow the `Implicit*Middleware` to ensure it does not respond for OPTIONS and HEAD requests.
weierophinney
force-pushed
the
feature/zend-expressive-router-rc2
branch
from
4e01200
to
b3a7a6a
Compare
weierophinney
changed the title
This change also requires us to add zend-diactoros in the skeleton explicitly.
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2018
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the skeleton to use zend-expressive-router 3.0.0rc4, as well as the compatible versions of each of the existing adapters:
One change necessary is for the pipeline to change the order of the various zend-expressive-router middleare;
MethodNotAllowedMiddlewareMUST follow theImplicit*Middlewareto ensure it does not respond for OPTIONS and HEAD requests.This fixes an issue reported about the
ImplicitOptionsMiddlewareandMethodNotAllowedMiddlewarenot correctly reporting allowed HTTP methods.It also updates the skeleton to zend-expressive 3.0.0rc3. Due to changes in that version, we must now also explicitly add zend-diactoros to the skeleton.