This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Document Expressive Skeleton 2 changes #456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
geerteltink
commented
Feb 23, 2017
•
geerteltink
commented
- Security advisories
- Development mode
- composer check
- composer clear-config-cache
- zend-component-installer
- zend-config-aggregator / ConfigProvider
- pipeline.php
- routes.php
- expressive-module tool
- in getting-started guide
Because `Zend\Expressive\Router\Route` is lenient in the middleware it composes, we cannot assume that the middleware composed is valid http-interop middleware in the dispatcher. As such, this patch does the following: - Updates `DispatchMiddleware` to compose a router, response prototype, and container, as all are necessary for preparing interop middleware shims. - Updates `DispatchMiddleware::process` to check if the middleware received is http-interop compatible; if not, it delegates to `MarshalMiddlewareTrait::prepareMiddleware()` to cast it to interop middleware.
geerteltink
changed the title
samsonasik
reviewed
Feb 24, 2017
doc/book/getting-started/skeleton.md
Outdated
| > to a full day: | ||
| > | ||
| > ```bash | ||
| > $ COMPOSER_PROCESS_TIMEOUT=86400 composer serve |
There was a problem hiding this comment.
it can be registered to ~/.composer/config.json that can be set by run command
composer config -g process-timeout 86400
So, no need to re-define it again.
There was a problem hiding this comment.
First time I read your comment I wanted to reply and say I wouldn't want to advise setting it in the config. But now that I read it again, you set it in the global config, which affects only your local dev environment. I actually like this a lot more than other solutions and I think it's cleaner.
However I think 1 day is a lot. What do you think, lower it to a few hours? You need a break once in a while any way.
There was a problem hiding this comment.
8 hours? ( usual a day work hours )
Put preferred versions first in `||` constraints To ensure the latest is selected first. This ensures that Composer does not need to do extra work if the first constraint matches, and is newer than the latter constraint.
Updated dependencies and travis configuration
Document Expressive Skeleton 2 changes
- Added more verbiage around setting composer timeouts, as you can also set them per-project instead of globally. - Added a section on the `expressive-module` tool, which will soon be included by default when selecting modular layouts. - Added a section on double-pass vs single-pass middleware, and why double-pass is now legacy.
|
@xtreamwayz I've pushed some edits and additions for you. 😄 |
weierophinney
added a commit
to weierophinney/zend-expressive
that referenced
this pull request
Mar 6, 2017
- Added more verbiage around setting composer timeouts, as you can also set them per-project instead of globally. - Added a section on the `expressive-module` tool, which will soon be included by default when selecting modular layouts. - Added a section on double-pass vs single-pass middleware, and why double-pass is now legacy.
15 tasks
|
Closed via #460 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.