This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Correct typo in aria attributes' names #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-saji
force-pushed
the
aria-attributes-by
branch
3 times, most recently
from
782d79c
to
4adba47
Compare
|
I think it can be pointed to master branch |
There should not be a dash before “by”: - http://www.w3.org/TR/wai-aria/states_and_properties#aria-labelledby - http://www.w3.org/TR/wai-aria/states_and_properties#aria-describedby This fixes a typo I introduced in zendframework/zendframework#5989.
marek-saji
force-pushed
the
aria-attributes-by
branch
from
4adba47
to
de16578
Compare
I rebased on master, but AFAIK there's no way to edit PR's target — should I remove this PR and create new one? |
|
create new one is better imo ;) |
weierophinney
pushed a commit
to zendframework/zendframework
that referenced
this pull request
Dec 20, 2016
- [#9](zendframework/zend-form#9) Correct typo in aria attributes' names There should not be a dash before “by”: - http://www.w3.org/TR/wai-aria/states_and_properties#aria-labelledby - http://www.w3.org/TR/wai-aria/states_and_properties#aria-describedby This fixes a typo I introduced in #5989. - [#12](zendframework/zend-form#12) Deprecated AllowEmpty and ContinueIfEmpty annotations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should not be a dash before “by”:
This fixes a typo I introduced in zendframework/zendframework#5989.