This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Avoid opening output stream twice #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlocati
force-pushed
the
hotfix/streamed-responses
branch
from
0d0feb2
to
5517542
Compare
mlocati
force-pushed
the
hotfix/streamed-responses
branch
from
061b379
to
45ea0f0
Compare
|
I updated this PR by adding a test to check that we can delete the downloaded file (previously this assertion would have failed on Windows). |
Xerkus
reviewed
Oct 13, 2017
| @@ -918,11 +923,17 @@ public function send(Request $request = null) | |||
| throw new Client\Exception\RuntimeException('Adapter does not support streaming'); | |||
| } | |||
|
|
|||
| $this->streamHandle = null; | |||
There was a problem hiding this comment.
I don't like that this code is relying on side effects
There was a problem hiding this comment.
Do you have a better suggestion?
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2018
|
Thanks, @mlocati. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we set the
outputstreamoption, the output file gets opened twice: here and here.The second handle can be managed (eg closed) by accessing the
Zend\Http\Response\Stream\getStream()method, but the first handle is simply lost: the file remains open (ie locked) until the end of the execution of the PHP script.Let's reuse the first file handle.