This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Normalize timeout exception #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mlocati can you provide a unit test to cover this new use case? Thanks, |
|
@mlocati can you send the PR against develop branch? Thanks! |
mlocati
force-pushed
the
normalize-timeout-exception
branch
from
69ca294
to
02037f0
Compare
Done. |
|
@mlocati thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Socket adapter meet timeout problems, it raises an
AdapterException\TimeoutExceptionexception.Let's do the same for the cURL client too.