Add unit test for zendframework/zendframework#5891

Updated the PhoneNumber test to support arrays of possible phone numbers to test against.
zendframework · Mar 4, 2014 · e4c17d1 · e4c17d1
1 parent f5f8cf1
commit e4c17d1
Showing 1 changed file with 29 additions and 23 deletions.
diff --git a/test/Validator/PhoneNumberTest.php b/test/Validator/PhoneNumberTest.php
@@ -2035,7 +2035,7 @@ class PhoneNumberTest extends \PHPUnit_Framework_TestCase
             'patterns' => array(
                 'example' => array(
                     'fixed' => '21234567',
-                    'mobile' => '81234567',
+                    'mobile' => array('81234567','71234567'),
                     'tollfree' => '18001234',
                     'emergency' => '118',
                 ),
@@ -3035,20 +3035,23 @@ public function testExampleNumbers()
     {
         foreach ($this->phone as $country => $parameters) {
             $this->validator->setCountry($country);
-            foreach ($parameters['patterns']['example'] as $type => $value) {
-                $this->validator->allowedTypes(array($type));
-                $this->assertTrue($this->validator->isValid($value));
+            foreach ($parameters['patterns']['example'] as $type => $values) {
+                $values = is_array($values) ? $values : array($values);
+                foreach ($values as $value) {
+                    $this->validator->allowedTypes(array($type));
+                    $this->assertTrue($this->validator->isValid($value));
 
-                // check with country code:
-                $countryCodePrefixed = $parameters['code'] . $value;
-                $this->assertTrue($this->validator->isValid($countryCodePrefixed));
+                    // check with country code:
+                    $countryCodePrefixed = $parameters['code'] . $value;
+                    $this->assertTrue($this->validator->isValid($countryCodePrefixed));
 
-                // check fully qualified E.123/E.164 international variants
-                $fullyQualifiedDoubleO = '00' . $parameters['code'] . $value;
-                $this->assertTrue($this->validator->isValid($fullyQualifiedDoubleO));
+                    // check fully qualified E.123/E.164 international variants
+                    $fullyQualifiedDoubleO = '00' . $parameters['code'] . $value;
+                    $this->assertTrue($this->validator->isValid($fullyQualifiedDoubleO));
 
-                $fullyQualifiedPlus = '+' . $parameters['code'] . $value;
-                $this->assertTrue($this->validator->isValid($fullyQualifiedPlus));
+                    $fullyQualifiedPlus = '+' . $parameters['code'] . $value;
+                    $this->assertTrue($this->validator->isValid($fullyQualifiedPlus));
+                }
             }
         }
     }
@@ -3058,20 +3061,23 @@ public function testExampleNumbersAgainstPossible()
         $this->validator->allowPossible(true);
         foreach ($this->phone as $country => $parameters) {
             $this->validator->setCountry($country);
-            foreach ($parameters['patterns']['example'] as $type => $value) {
-                $this->validator->allowedTypes(array($type));
-                $this->assertTrue($this->validator->isValid($value));
+            foreach ($parameters['patterns']['example'] as $type => $values) {
+                $values = is_array($values) ? $values : array($values);
+                foreach ($values as $value) {
+                    $this->validator->allowedTypes(array($type));
+                    $this->assertTrue($this->validator->isValid($value));
 
-                // check with country code:
-                $countryCodePrefixed = $parameters['code'] . $value;
-                $this->assertTrue($this->validator->isValid($countryCodePrefixed));
+                    // check with country code:
+                    $countryCodePrefixed = $parameters['code'] . $value;
+                    $this->assertTrue($this->validator->isValid($countryCodePrefixed));
 
-                // check fully qualified E.123/E.164 international variants
-                $fullyQualifiedDoubleO = '00'. $parameters['code'] . $value;
-                $this->assertTrue($this->validator->isValid($fullyQualifiedDoubleO), $fullyQualifiedDoubleO);
+                    // check fully qualified E.123/E.164 international variants
+                    $fullyQualifiedDoubleO = '00'. $parameters['code'] . $value;
+                    $this->assertTrue($this->validator->isValid($fullyQualifiedDoubleO), $fullyQualifiedDoubleO);
 
-                $fullyQualifiedPlus = '+'. $parameters['code'] . $value;
-                $this->assertTrue($this->validator->isValid($fullyQualifiedPlus), $fullyQualifiedPlus);
+                    $fullyQualifiedPlus = '+'. $parameters['code'] . $value;
+                    $this->assertTrue($this->validator->isValid($fullyQualifiedPlus), $fullyQualifiedPlus);
+                }
             }
         }
     }