Added test to check if possible to set country with context

[svycka]

I guess this was desired behavior but didn't worked.

this is extremely useful for example with input filters, example:

class User extends InputFilter
{
    public function __construct()
    {
        $this->add([
            'name'       => 'country_code',
            'required'   => true,
            'validators' => [
                new CountryCode()
            ],
        ]);
        $this->add([
            'name'       => 'phone',
            'required'   => true,
            'validators' => [
                [
                    'name' => 'PhoneNumber',
                    'options' => [
                        'country' => 'country_code',
                    ]
                ],
        ]);
    }
}

before I had to wrap PhoneNumber into callback validator and pass country in constructor.

[svycka]

I know changing tests is not good but maybe not a BC break? Anyway getCountry() is used only in one place and I covered it so maybe not a problem?

[weierophinney]

Your changes make sense. We'll want to be able to retrieve the original version, but also validate in a case-insensitive manner. This is a good solution.

[svycka]

workaround example:

class User extends InputFilter
{
    public function __construct()
    {
        $this->add([
            'name'       => 'country_code',
            'required'   => true,
            'validators' => [
                new CountryCode()
            ],
        ]);
        $this->add([
            'name'       => 'phone',
            'required'   => true,
            'validators' => [
                'name' => 'Zend\Validator\Callback',
                'options'  => array(
                    'messages' => [
                        \Zend\Validator\Callback::INVALID_VALUE => 'Invalid phone number.',
                    ],
                    'callback' => function ($phone, $context) {

                        $phoneValidator = new PhoneNumber([
                            'country' => $context['country_code'],
                        ]);
                        return $phoneValidator->isValid($phone);
                    },
                ),
            ],
        ]);
    }
}

[weierophinney]

Thanks, @svycka