Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Adds a section for integration in mvc and expressive applications #183

Closed
wants to merge 14 commits into from
Closed

Adds a section for integration in mvc and expressive applications #183

wants to merge 14 commits into from

Conversation

froschdesign
Copy link
Member

No description provided.

@froschdesign
Copy link
Member Author

Related to laminas/documentation#8

@Xerkus
Copy link
Member

Xerkus commented May 23, 2019

Unless mentioned elsewhere, add mention that zend-component-provider can auto-register ConfigProvider/Module with application on component installation.

@froschdesign
Copy link
Member Author

@Xerkus
I'm thinking about extracting the whole process of installation. This would reduce the number of steps in the current descriptions and repetitions are avoided.

@froschdesign
Copy link
Member Author

Related to laminas/documentation#12

@froschdesign froschdesign removed the WIP label Aug 23, 2019
weierophinney
weierophinney suggested changes Oct 28, 2019
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this approach, and I think it will go a long way towards showing developers that the components can be used in a variety of applications, not just MVC, Expressive, etc.

Just a few comments for improvement.

docs/book/application-integration/usage-in-a-zend-expressive-application.md Outdated Show resolved Hide resolved
docs/book/application-integration/usage-in-a-zend-expressive-application.md Outdated Show resolved Hide resolved
docs/book/application-integration/usage-in-a-zend-expressive-application.md Outdated Show resolved Hide resolved
docs/book/application-integration/usage-in-a-zend-expressive-application.md Outdated

### Register Handler

Extend the configuration provider of the module to register the input-filter,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would maybe note "If you haven't already, register the handler and its factory with your configuration provider."

In most cases, this should already be the case, particularly if they used the console tooling to originally create the handler.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I will recheck the handling with the console tooling.

weierophinney
weierophinney suggested changes Nov 5, 2019
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I've made a few wording suggestions, and also noted that there's still inconsistent usage of "input filter" vs "input-filter" throughout.

docs/book/application-integration/usage-in-a-zend-expressive-application.md Outdated Show resolved Hide resolved
docs/book/application-integration/usage-in-a-zend-expressive-application.md Outdated Show resolved Hide resolved
docs/book/application-integration/usage-in-a-zend-mvc-application.md Outdated Show resolved Hide resolved
docs/book/application-integration/usage-in-a-zend-mvc-application.md Outdated Show resolved Hide resolved
docs/book/application-integration/usage-in-a-zend-mvc-application.md Outdated Show resolved Hide resolved
@froschdesign
Copy link
Member Author

@weierophinney
I added your suggestions and corrections. 👍
I also reduced the registration of handler / controller and input filter to one step.

weierophinney
weierophinney approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weierophinney weierophinney weierophinney approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@froschdesign @Xerkus @weierophinney