Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

PHPDoc: Message#getBody() can also return a string #190

Closed
wants to merge 1 commit into from
Closed

PHPDoc: Message#getBody() can also return a string #190

wants to merge 1 commit into from

Conversation

Slamdunk
Copy link
Contributor

@Slamdunk Slamdunk commented Jan 5, 2018

Body can also be a string:

zend-mail/src/Message.php

Lines 17 to 22 in d787bf7

/**
* Content of the message
*
* @var string|object
*/
protected $body;

@Ocramius Ocramius self-assigned this Mar 1, 2018
@Ocramius Ocramius added this to the 2.9.0 milestone Mar 1, 2018
Ocramius
Ocramius approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius changed the title PHPDoc: Message type mismatch fix PHPDoc: Message#getBody() can also return a string Mar 1, 2018
Ocramius added a commit that referenced this pull request Mar 1, 2018
@Ocramius
Merge branch 'docs/#190-fix-docblock-on-message-get-body' into develop
0b7b501 
Close #190
@Ocramius
Copy link
Member

Ocramius commented Mar 1, 2018

@Slamdunk thanks! Manually merged via 0b7b501

@Ocramius Ocramius closed this Mar 1, 2018
@Slamdunk Slamdunk deleted the patch-2 branch March 2, 2018 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Slamdunk @Ocramius