This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fix for Forward in zend-eventmanager v3 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually, EventManager returns an ARRAY on `$sharedEvents->getListeners` and the way it was implemented the `listenersToDetach` it wasn't working. I don't know if in V2 it is the same thing, so, this pull request FIX this method and a problem from rendering the View two times. Like this old bug: http://zend-framework-community.634137.n4.nabble.com/Double-rendering-with-forward-plugin-td4656067i20.html Thanks, Rodrigo
|
@rwrz Travis tests against lowest supported, current lockfile, and latest dependencies; the fact you have a green light from Travis indicates it works against zend-eventmanager v2 as well. 😄 |
| } | ||
| // v3 |
There was a problem hiding this comment.
This comment can be removed, as the logic below executes for either version. (I'll do that during merge.)
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2016
Fix for Forward in zend-eventmanager v3
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually,
EventManager returns an ARRAY on
$sharedEvents->getListenersand the way it was implemented thelistenersToDetachit wasn't working.I don't know if in V2 it is the same thing, so, this pull request FIX this method and a problem from rendering the View two times.
Like this old bug: http://zend-framework-community.634137.n4.nabble.com/Double-rendering-with-forward-plugin-td4656067i20.html
Someone can check if it works on
zend-eventmanagerv2?Thanks,
Rodrigo