Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Add php 7.3 to travis builds #44

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Conversation

Xerkus
Copy link
Member

@Xerkus Xerkus commented Oct 15, 2018

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?

  • Is this related to documentation?

@Xerkus Xerkus merged commit cb49e85 into zendframework:master Oct 15, 2018
Xerkus added a commit that referenced this pull request Oct 15, 2018
Xerkus added a commit that referenced this pull request Oct 15, 2018
@Xerkus Xerkus added this to the 1.0.2 milestone Oct 15, 2018
@Xerkus Xerkus deleted the hotfix/php73 branch October 15, 2018 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant